Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set last gateway location on claim #7262

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

johanstokking
Copy link
Member

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/issues/4256

This sets the last known location on claim.

Changes

  • Add gateway metadata to Claim return value
  • Get the last location from The Things Gateway Controller, could be observed via WiFi scan or cell tower or GPS if the gateway already powered on before it gets claimed
  • Unrelated but small improvement: Fix log namespace and increase log level for failed connects

Testing

Steps
  1. Turn on supported gateway
  2. Claim gateway
Results

Should show location on the map immediately after claiming.

Regressions

None expected

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking requested review from a team as code owners August 23, 2024 18:40
@johanstokking johanstokking added this to the v3.32.1 milestone Aug 23, 2024
@johanstokking johanstokking self-assigned this Aug 23, 2024
@github-actions github-actions bot added c/gateway server This is related to the Gateway Server dependencies Pull requests that update a dependency file tooling Development tooling labels Aug 23, 2024
@johanstokking johanstokking modified the milestones: v3.32.1, v3.32.0 Aug 26, 2024
@johanstokking johanstokking changed the base branch from v3.32 to release/v3.32.0 August 26, 2024 09:37
@johanstokking johanstokking requested a review from a team as a code owner August 26, 2024 09:37
@johanstokking johanstokking requested review from PavelJankoski and removed request for a team August 26, 2024 09:37
@johanstokking johanstokking force-pushed the feature/update-location-on-claim branch from 74ec750 to 513fa47 Compare August 26, 2024 09:38
@johanstokking johanstokking merged commit 5717aa4 into release/v3.32.0 Aug 26, 2024
15 checks passed
@johanstokking johanstokking deleted the feature/update-location-on-claim branch August 26, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway server This is related to the Gateway Server dependencies Pull requests that update a dependency file tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants